Hans,
Not limited to this part of code, though for example, we have in nestkernle/simulation_manager.cpp
[...] #pragma omp target teams distribute parallel for for(int i=0;i<len;i++) { // We update in a parallel region. Therefore, we need to catch // exceptions here and then handle them after the parallel region. //try //{ if ( not( *node )->is_frozen() ) { ( *node )->update( clock_, from_step_, to_step_ ); } //} /*catch ( std::exception& e ) { // so throw the exception after parallel region exceptions_raised.at( tid ) = lockPTR< WrappedThreadException >( new WrappedThreadException( e ) ); }*/ ++node; }
OpenMP offload doesn't support exception handling on devices, so any loop that can be offloadable, but contains exception handling, can we safely comment out?
Itaru.
On Tue, Apr 30, 2019 at 6:49 AM Hans Ekkehard Plesser < hans.ekkehard.plesser@nmbu.no> wrote:
Dear Itaru,
Could you be more specific about where you would like to remove exception handling code and why? In general, I would be rather reluctant to remove exception handling code.
Best, Hans Ekkehard
On 26 Apr 2019, at 13:56, Itaru Kitayama itaru.kitayama@gmail.com
wrote:
Hi, Am I able to safely comment out all those exception handling codes
provided
they're provided for the defensive purposes? I ask because I am trying to insert offloading directives into the NEST code base wherever I can.
Thanks, Itaru. _______________________________________________ NEST Users mailing list -- users@nest-simulator.org To unsubscribe send an email to users-leave@nest-simulator.org
--
Prof. Dr. Hans Ekkehard Plesser Head, Data Science Section
Faculty of Science and Technology Norwegian University of Life Sciences PO Box 5003, 1432 Aas, Norway
Phone +47 6723 1560 Email hans.ekkehard.plesser@nmbu.no Home http://arken.nmbu.no/~plesser